From 325fdc3f3a3087a35b09e445df3ce34b7e4e0bf6 Mon Sep 17 00:00:00 2001
From: Oscar Hinton <Hinton@users.noreply.github.com>
Date: Mon, 3 Mar 2025 16:59:50 +0100
Subject: [PATCH] [PM-18659] Remove console logs from importers unit tests
 (#13583)

* Remove console logs from importers unit tests

* Add fixme
---
 libs/importer/src/importers/base-importer.ts                 | 1 +
 .../src/importers/passsordxp/passwordxp-csv-importer.spec.ts | 2 ++
 libs/importer/src/importers/roboform-csv-importer.spec.ts    | 5 +++++
 libs/importer/src/importers/securesafe-csv-importer.spec.ts  | 5 +++++
 4 files changed, 13 insertions(+)

diff --git a/libs/importer/src/importers/base-importer.ts b/libs/importer/src/importers/base-importer.ts
index 1992f676e29..90af5344cfc 100644
--- a/libs/importer/src/importers/base-importer.ts
+++ b/libs/importer/src/importers/base-importer.ts
@@ -20,6 +20,7 @@ import { ImportResult } from "../models/import-result";
 export abstract class BaseImporter {
   organizationId: string = null;
 
+  // FIXME: This should be replaced by injecting the log service.
   protected logService: LogService = new ConsoleLogService(false);
 
   protected newLineRegex = /(?:\r\n|\r|\n)/;
diff --git a/libs/importer/src/importers/passsordxp/passwordxp-csv-importer.spec.ts b/libs/importer/src/importers/passsordxp/passwordxp-csv-importer.spec.ts
index 1bcc79723ab..0decd1e2830 100644
--- a/libs/importer/src/importers/passsordxp/passwordxp-csv-importer.spec.ts
+++ b/libs/importer/src/importers/passsordxp/passwordxp-csv-importer.spec.ts
@@ -48,6 +48,8 @@ describe("PasswordXPCsvImporter", () => {
 
   beforeEach(() => {
     importer = new PasswordXPCsvImporter();
+    // Importers currently create their own ConsoleLogService. This should be replaced by injecting a test log service.
+    jest.spyOn(console, "warn").mockImplementation();
   });
 
   it("should return success false if CSV data is null", async () => {
diff --git a/libs/importer/src/importers/roboform-csv-importer.spec.ts b/libs/importer/src/importers/roboform-csv-importer.spec.ts
index 2779a9ddb64..dd385e10b8d 100644
--- a/libs/importer/src/importers/roboform-csv-importer.spec.ts
+++ b/libs/importer/src/importers/roboform-csv-importer.spec.ts
@@ -5,6 +5,11 @@ import { data as dataNoFolder } from "./spec-data/roboform-csv/empty-folders";
 import { data as dataFolder } from "./spec-data/roboform-csv/with-folders";
 
 describe("Roboform CSV Importer", () => {
+  beforeEach(() => {
+    // Importers currently create their own ConsoleLogService. This should be replaced by injecting a test log service.
+    jest.spyOn(console, "warn").mockImplementation();
+  });
+
   it("should parse CSV data", async () => {
     const importer = new RoboFormCsvImporter();
     const result = await importer.parse(dataNoFolder);
diff --git a/libs/importer/src/importers/securesafe-csv-importer.spec.ts b/libs/importer/src/importers/securesafe-csv-importer.spec.ts
index 799c3c6e9d5..e5ddbf75382 100644
--- a/libs/importer/src/importers/securesafe-csv-importer.spec.ts
+++ b/libs/importer/src/importers/securesafe-csv-importer.spec.ts
@@ -51,6 +51,11 @@ const CipherData = [
 ];
 
 describe("SecureSafe CSV Importer", () => {
+  beforeEach(() => {
+    // Importers currently create their own ConsoleLogService. This should be replaced by injecting a test log service.
+    jest.spyOn(console, "warn").mockImplementation();
+  });
+
   CipherData.forEach((data) => {
     it(data.title, async () => {
       const importer = new SecureSafeCsvImporter();