mirror of
https://github.com/chatwoot/chatwoot.git
synced 2026-06-13 21:01:16 +08:00
e0ef007047
Fixes the following issues - https://chatwoot-p3.sentry.io/issues/5966466083 - https://chatwoot-p3.sentry.io/issues/5966497518 - https://chatwoot-p3.sentry.io/issues/5966555379 For the first one, I am not sure if the fix is 100% correct, since I was not able to reproduce, but I am confident it will work. For both, 1st and 2nd issues, the problem came from the fact that we set individual records to `undefined` when the intent was to remove it, explicitly using delete fixes the issue. ### Whats up with the store changes? Glad you asked, this comes down to Vue reactivity, previously Vue didn't track undefined strictly, it just kinda ignored it, in Vue 3, the reactivity changed significantly when they introduced ES6 proxies. The Proxy tracks all property changes, including those set to undefined, so properties remain enumerable. So to delete a record, we actually have to the delete it using the delete keyword, or replace the parent object with a new object splicing the object to be deleted out. I am assuming it worked earlier because VueX 3 reactivity was using Object.defineProperty. Setting it to undefined might have "deleted" it earlier --------- Co-authored-by: Pranav <pranav@chatwoot.com> |
||
|---|---|---|
| .. | ||
| dashboard | ||
| design-system | ||
| entrypoints | ||
| portal | ||
| sdk | ||
| shared | ||
| superadmin_pages | ||
| survey | ||
| v3 | ||
| widget | ||
| histoire.setup.ts | ||