mirror of
https://github.com/chatwoot/chatwoot.git
synced 2026-06-13 21:01:16 +08:00
70a65e2c34
# Pull Request Template
## Description
**Issue:** When typing "@" in reply mode and then switching to private
note mode, the user mentions menu remains visible and cannot be
dismissed.
**Cause:** The Prose Mirror suggestion plugin for "@" was active in both
reply modes (normal and private). When triggered in normal reply mode
and then switching to private note mode, the menu would remain open and
couldn't be dismissed.
**Solution**
```
createSuggestionPlugin({
trigger: '@',
showMenu: showUserMentions,
searchTerm: mentionSearchKey,
isAllowed: () => props.isPrivate, // Only allow @ mentions in private note mode
}),
```
1. By setting `isAllowed: () => props.isPrivate`, the @ mention trigger
will only activate when in private note mode
2. In normal reply mode, the plugin won't activate at all since
`isAllowed` returns false
3. This prevents the menu from being triggered in the wrong context and
fix the scenario where the menu gets stuck.
## Type of change
- [x] Bug fix (non-breaking change which fixes an issue)
## How Has This Been Tested?
### Loom video
**Before**
https://www.loom.com/share/5333f0c6498d4a9ea4d220b1de1b608c?sid=1425f24f-2c6f-4ff5-aab3-23c3203d2e05
**After**
https://www.loom.com/share/9f183c76d6a94b618a7c2aaed280b780?sid=19ef08b8-2b70-434b-ad5a-267410212e11
## Checklist:
- [x] My code follows the style guidelines of this project
- [x] I have performed a self-review of my code
- [ ] I have commented on my code, particularly in hard-to-understand
areas
- [ ] I have made corresponding changes to the documentation
- [x] My changes generate no new warnings
- [ ] I have added tests that prove my fix is effective or that my
feature works
- [x] New and existing unit tests pass locally with my changes
- [ ] Any dependent changes have been merged and published in downstream
modules
|
||
|---|---|---|
| .. | ||
| conversation | ||
| DashboardApp | ||
| FilterInput | ||
| forms | ||
| mentions | ||
| modal | ||
| WootWriter | ||
| AIAssistanceButton.vue | ||
| AIAssistanceCTAButton.vue | ||
| AIAssistanceModal.vue | ||
| AICTAModal.vue | ||
| AILoader.vue | ||
| AttachmentsPreview.vue | ||
| AutomationActionInput.vue | ||
| AutomationActionTeamMessageInput.vue | ||
| AutomationFileInput.vue | ||
| Avatar.vue | ||
| BackButton.vue | ||
| ChannelItem.vue | ||
| ChatTypeTabs.vue | ||
| ColorPicker.vue | ||
| EmptyState.vue | ||
| FeatureToggle.vue | ||
| InboxName.vue | ||
| LoadingState.vue | ||
| SettingIntroBanner.vue | ||
| ShowMore.vue | ||
| TableFooter.vue | ||
| TableFooterPagination.vue | ||
| TableFooterResults.vue | ||
| TableHeaderCell.vue | ||
| Thumbnail.spec.js | ||
| Thumbnail.vue | ||
| ThumbnailGroup.vue | ||
| UserAvatarWithName.vue | ||
| VideoCallButton.vue | ||