mirror of
https://github.com/chatwoot/chatwoot.git
synced 2026-06-28 21:01:02 +08:00
699b12b1d3
# Pull Request Template ## Description This PR includes, block inline images in message signatures and prevent auto signature insertion when editor is disabled. - Strip inline base64 images from signature on save and show warning message - Add `INLINE_IMAGE_WARNING` translation key for signature inline image removal notification - Add disabled check to `addSignature()` to prevent signature insertion when editor is disabled - Add `isEditorDisabled` checks to signature toggle logic in `toggleSignatureForDraft()`, `replaceText()`, and `clearMessage()` - Remove unused `replaceText` from the codebase, which belongs to old `textarea` editor Fixes https://linear.app/chatwoot/issue/CW-6588/the-browser-hangs-when-the-message-signature-contains-inline-image ## Type of change - [x] Bug fix (non-breaking change which fixes an issue) ## How Has This Been Tested? ### Loom video https://www.loom.com/share/fb556b46a12a4308a737eed732d5ed73 ## Checklist: - [x] My code follows the style guidelines of this project - [x] I have performed a self-review of my code - [ ] I have commented on my code, particularly in hard-to-understand areas - [ ] I have made corresponding changes to the documentation - [x] My changes generate no new warnings - [ ] I have added tests that prove my fix is effective or that my feature works - [x] New and existing unit tests pass locally with my changes - [ ] Any dependent changes have been merged and published in downstream modules --------- Co-authored-by: Muhsin Keloth <muhsinkeramam@gmail.com> |
||
|---|---|---|
| .. | ||
| AnalyticsHelper | ||
| AudioAlerts | ||
| CacheHelper | ||
| commandbar | ||
| snoozeDateParser | ||
| specs | ||
| actionCable.js | ||
| actionQueryGenerator.js | ||
| agentHelper.js | ||
| APIHelper.js | ||
| auditlogHelper.js | ||
| automationHelper.js | ||
| commons.js | ||
| conversationHelper.js | ||
| customViewsHelper.js | ||
| DOMHelpers.js | ||
| downloadHelper.js | ||
| editorHelper.js | ||
| emailQuoteExtractor.js | ||
| featureHelper.js | ||
| filterQueryGenerator.js | ||
| flag.js | ||
| inbox.js | ||
| labelColor.js | ||
| permissionsHelper.js | ||
| portalHelper.js | ||
| preChat.js | ||
| pushHelper.js | ||
| quotedEmailHelper.js | ||
| ReconnectService.js | ||
| routeHelpers.js | ||
| scriptHelpers.js | ||
| snoozeHelpers.js | ||
| states.js | ||
| templateHelper.js | ||
| themeHelper.js | ||
| Timer.js | ||
| uploadHelper.js | ||
| URLHelper.js | ||
| validations.js | ||
| voice.js | ||