chatwoot/spec/services/line/send_on_line_service_spec.rb
Muhsin Keloth 4cce7f6ad8
fix(line): Use non-expiring URLs for image and video messages (#13949)
Images and videos sent from Chatwoot to LINE inboxes fail to display on
the LINE mobile app — users see expired markers, broken thumbnails, or
missing images. This happens because LINE mobile lazy-loads images
rather than downloading them immediately, and the ActiveStorage signed
URLs expire after 5 minutes.

Closes
https://linear.app/chatwoot/issue/CW-6696/line-messaging-with-image-or-video-may-not-show-when-client-inactive

## How to reproduce

1. Create a LINE inbox and start a chat from the LINE mobile app
2. Close the LINE mobile app
3. Send an image from Chatwoot to that chat
4. Wait 7-8 minutes (past the 5-minute URL expiration)
5. Open the LINE mobile app — the image is broken/expired

## What changed

- **`originalContentUrl`**: switched from `download_url` (signed, 5-min
expiry) to `file_url` (permanent redirect-based URL)
- **`previewImageUrl`**: switched to `thumb_url` (250px resized
thumbnail meeting LINE's 1MB/240x240 recommendation), with fallback to
`file_url` for non-image attachments like video

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-authored-by: Sojan Jose <sojan@pepalo.com>
2026-04-01 17:29:12 +05:30

217 lines
7.0 KiB
Ruby

require 'rails_helper'
describe Line::SendOnLineService do
describe '#perform' do
let(:line_client) { double }
let(:line_channel) { create(:channel_line) }
let(:message) do
create(:message, message_type: :outgoing, content: 'test',
conversation: create(:conversation, inbox: line_channel.inbox))
end
before do
allow(Line::Bot::Client).to receive(:new).and_return(line_client)
end
context 'when message send' do
it 'calls @channel.client.push_message' do
allow(line_client).to receive(:push_message)
expect(line_client).to receive(:push_message)
described_class.new(message: message).perform
end
end
context 'when message send fails without details' do
let(:error_response) do
{
'message' => 'The request was invalid'
}.to_json
end
before do
allow(line_client).to receive(:push_message).and_return(OpenStruct.new(code: '400', body: error_response))
end
it 'updates the message status to failed' do
described_class.new(message: message).perform
message.reload
expect(message.status).to eq('failed')
end
it 'updates the external error without details' do
described_class.new(message: message).perform
message.reload
expect(message.external_error).to eq('The request was invalid')
end
end
context 'when message send fails with details' do
let(:error_response) do
{
'message' => 'The request was invalid',
'details' => [
{
'property' => 'messages[0].text',
'message' => 'May not be empty'
}
]
}.to_json
end
before do
allow(line_client).to receive(:push_message).and_return(OpenStruct.new(code: '400', body: error_response))
end
it 'updates the message status to failed' do
described_class.new(message: message).perform
message.reload
expect(message.status).to eq('failed')
end
it 'updates the external error with details' do
described_class.new(message: message).perform
message.reload
expect(message.external_error).to eq('The request was invalid, messages[0].text: May not be empty')
end
end
context 'when message send succeeds' do
let(:success_response) do
{
'message' => 'ok'
}.to_json
end
before do
allow(line_client).to receive(:push_message).and_return(OpenStruct.new(code: '200', body: success_response))
end
it 'updates the message status to delivered' do
described_class.new(message: message).perform
message.reload
expect(message.status).to eq('delivered')
end
end
context 'with message input_select' do
let(:success_response) do
{
'message' => 'ok'
}.to_json
end
let(:expect_message) do
{
type: 'flex',
altText: 'test',
contents: {
type: 'bubble',
body: {
type: 'box',
layout: 'vertical',
contents: [
{
type: 'text',
text: 'test',
wrap: true
},
{
type: 'button',
style: 'link',
height: 'sm',
action: {
type: 'message',
label: 'text 1',
text: 'value 1'
}
},
{
type: 'button',
style: 'link',
height: 'sm',
action: {
type: 'message',
label: 'text 2',
text: 'value 2'
}
}
]
}
}
}
end
it 'sends the message with input_select' do
message = create(
:message, message_type: :outgoing, content: 'test', content_type: 'input_select',
content_attributes: { 'items' => [{ 'title' => 'text 1', 'value' => 'value 1' }, { 'title' => 'text 2', 'value' => 'value 2' }] },
conversation: create(:conversation, inbox: line_channel.inbox)
)
expect(line_client).to receive(:push_message).with(
message.conversation.contact_inbox.source_id,
expect_message
).and_return(OpenStruct.new(code: '200', body: success_response))
described_class.new(message: message).perform
end
end
context 'with message attachments' do
it 'sends the message with text and attachments' do
attachment = message.attachments.new(account_id: message.account_id, file_type: :image)
attachment.file.attach(io: Rails.root.join('spec/assets/avatar.png').open, filename: 'avatar.png', content_type: 'image/png')
attachment.save!
expected_original_url_regex = %r{rails/active_storage/blobs/redirect/[a-zA-Z0-9=_\-+]+/avatar\.png}
expected_preview_url_regex = %r{rails/active_storage/representations/redirect/[a-zA-Z0-9=_\-+]+/[a-zA-Z0-9=_\-+]+/avatar\.png}
expect(line_client).to receive(:push_message).with(
message.conversation.contact_inbox.source_id,
[
{ type: 'text', text: message.content },
{
type: 'image',
originalContentUrl: match(expected_original_url_regex),
previewImageUrl: match(expected_preview_url_regex)
}
]
)
described_class.new(message: message).perform
end
it 'sends the message with attachments only' do
attachment = message.attachments.new(account_id: message.account_id, file_type: :image)
attachment.file.attach(io: Rails.root.join('spec/assets/avatar.png').open, filename: 'avatar.png', content_type: 'image/png')
attachment.save!
message.update!(content: nil)
expected_original_url_regex = %r{rails/active_storage/blobs/redirect/[a-zA-Z0-9=_\-+]+/avatar\.png}
expected_preview_url_regex = %r{rails/active_storage/representations/redirect/[a-zA-Z0-9=_\-+]+/[a-zA-Z0-9=_\-+]+/avatar\.png}
expect(line_client).to receive(:push_message).with(
message.conversation.contact_inbox.source_id,
[
{
type: 'image',
originalContentUrl: match(expected_original_url_regex),
previewImageUrl: match(expected_preview_url_regex)
}
]
)
described_class.new(message: message).perform
end
it 'sends the message with text only' do
message.attachments.destroy_all
expect(line_client).to receive(:push_message).with(
message.conversation.contact_inbox.source_id,
{ type: 'text', text: message.content }
)
described_class.new(message: message).perform
end
end
end
end