mirror of
https://github.com/chatwoot/chatwoot.git
synced 2026-06-04 21:02:35 +08:00
eaffad12e7
# Pull Request Template ## Description We need to pass on trace level attributes down to the spans inside them like tool calls, observations, etc. This way, we can filter observations based on trace level attributes. ## Type of change - [x] Bug fix (non-breaking change which fixes an issue) ## How Has This Been Tested? Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration. Attributes added to observation metadata for easy filtering <img width="1327" height="708" alt="image" src="https://github.com/user-attachments/assets/8f1d1bf8-cde4-481d-a2c2-7920ad2fc52e" /> added a `generation_stage` to differentiate llm_calls that call tools vs those that generate a `final_response` <img width="1806" height="968" alt="CleanShot 2026-06-03 at 15 11 09@2x" src="https://github.com/user-attachments/assets/db1fa8e0-7f2d-404b-a719-27a16d400442" /> propagated attributes to tool calls for future use <img width="903" height="517" alt="image" src="https://github.com/user-attachments/assets/edc61ce8-93db-465c-a66e-043138e2dc15" /> ## Checklist: - [x] My code follows the style guidelines of this project - [x] I have performed a self-review of my code - [x] I have commented on my code, particularly in hard-to-understand areas - [ ] I have made corresponding changes to the documentation - [x] My changes generate no new warnings - [x] I have added tests that prove my fix is effective or that my feature works - [x] New and existing unit tests pass locally with my changes - [x] Any dependent changes have been merged and published in downstream modules
62 lines
2.3 KiB
Ruby
62 lines
2.3 KiB
Ruby
module Captain::ToolInstrumentation
|
|
extend ActiveSupport::Concern
|
|
include Integrations::LlmInstrumentationConstants
|
|
|
|
private
|
|
|
|
# Custom instrumentation for tool flows - outputs just the message (not full hash)
|
|
def instrument_tool_session(params)
|
|
return yield unless ChatwootApp.otel_enabled?
|
|
|
|
response = nil
|
|
executed = false
|
|
with_propagated_langfuse_attributes(params) do
|
|
tracer.in_span(params[:span_name]) do |span|
|
|
set_tool_session_attributes(span, params)
|
|
response = yield
|
|
executed = true
|
|
span.set_attribute(ATTR_LANGFUSE_OBSERVATION_OUTPUT, response[:message] || response.to_json)
|
|
set_tool_session_error_attributes(span, response) if response.is_a?(Hash)
|
|
end
|
|
end
|
|
response
|
|
rescue StandardError => e
|
|
ChatwootExceptionTracker.new(e, account: account).capture_exception
|
|
executed ? response : yield
|
|
end
|
|
|
|
def set_tool_session_attributes(span, params)
|
|
set_metadata_attributes(span, params)
|
|
span.set_attribute(ATTR_LANGFUSE_OBSERVATION_INPUT, params[:messages].to_json)
|
|
end
|
|
|
|
def set_tool_session_error_attributes(span, response)
|
|
error = response[:error] || response['error']
|
|
return if error.blank?
|
|
|
|
span.set_attribute(ATTR_GEN_AI_RESPONSE_ERROR, error.to_json)
|
|
span.status = OpenTelemetry::Trace::Status.error(error.to_s.truncate(1000))
|
|
end
|
|
|
|
def record_generation(chat, message, model)
|
|
return unless ChatwootApp.otel_enabled?
|
|
return unless message.respond_to?(:role) && message.role.to_s == 'assistant'
|
|
|
|
tracer.in_span("llm.#{event_name}.generation") do |span|
|
|
apply_current_langfuse_attributes(span)
|
|
span.set_attribute(ATTR_GEN_AI_PROVIDER, 'openai')
|
|
span.set_attribute(ATTR_GEN_AI_REQUEST_MODEL, model)
|
|
span.set_attribute(ATTR_GEN_AI_USAGE_INPUT_TOKENS, message.input_tokens)
|
|
span.set_attribute(ATTR_GEN_AI_USAGE_OUTPUT_TOKENS, message.output_tokens) if message.respond_to?(:output_tokens)
|
|
span.set_attribute(ATTR_LANGFUSE_OBSERVATION_INPUT, format_chat_messages(chat))
|
|
span.set_attribute(ATTR_LANGFUSE_OBSERVATION_OUTPUT, message.content.to_s) if message.respond_to?(:content)
|
|
end
|
|
rescue StandardError => e
|
|
Rails.logger.warn "Failed to record generation: #{e.message}"
|
|
end
|
|
|
|
def format_chat_messages(chat)
|
|
chat.messages[0...-1].map { |m| { role: m.role.to_s, content: m.content.to_s } }.to_json
|
|
end
|
|
end
|