mirror of
https://github.com/chatwoot/chatwoot.git
synced 2026-06-04 21:02:35 +08:00
# Pull Request Template ## Description fixes: https://linear.app/chatwoot/issue/AI-151/captains-super-admin-config-dont-get-applied-into-rails-without ## Type of change - [x] Bug fix (non-breaking change which fixes an issue) ## How Has This Been Tested? Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration. specs and locally To test locally: go to super admin -> settings -> captain -> Change endpoint to something incorrect go to local app -> captain -> playground -> try chatting (should fail due to incorrect endpoint) now in super admin captain settings, set the correct endpoint then chat in playground. Now it should work. Current develop code doesn't reflect the changes in installation config for captain instantly, needs a server restart. ## Checklist: - [x] My code follows the style guidelines of this project - [x] I have performed a self-review of my code - [x] I have commented on my code, particularly in hard-to-understand areas - [ ] I have made corresponding changes to the documentation - [x] My changes generate no new warnings - [x] I have added tests that prove my fix is effective or that my feature works - [x] New and existing unit tests pass locally with my changes - [x] Any dependent changes have been merged and published in downstream modules
75 lines
2.2 KiB
Ruby
75 lines
2.2 KiB
Ruby
# == Schema Information
|
|
#
|
|
# Table name: installation_configs
|
|
#
|
|
# id :bigint not null, primary key
|
|
# locked :boolean default(TRUE), not null
|
|
# name :string not null
|
|
# serialized_value :jsonb not null
|
|
# created_at :datetime not null
|
|
# updated_at :datetime not null
|
|
#
|
|
# Indexes
|
|
#
|
|
# index_installation_configs_on_name (name) UNIQUE
|
|
# index_installation_configs_on_name_and_created_at (name,created_at) UNIQUE
|
|
#
|
|
class InstallationConfig < ApplicationRecord
|
|
CAPTAIN_LLM_CONFIG_KEYS = %w[
|
|
CAPTAIN_OPEN_AI_API_KEY
|
|
CAPTAIN_OPEN_AI_ENDPOINT
|
|
CAPTAIN_OPEN_AI_MODEL
|
|
].freeze
|
|
|
|
RESTART_REQUIRED_CONFIG_KEYS = (CAPTAIN_LLM_CONFIG_KEYS + %w[
|
|
LANGFUSE_BASE_URL
|
|
LANGFUSE_PUBLIC_KEY
|
|
LANGFUSE_SECRET_KEY
|
|
OTEL_PROVIDER
|
|
]).freeze
|
|
|
|
# https://stackoverflow.com/questions/72970170/upgrading-to-rails-6-1-6-1-causes-psychdisallowedclass-tried-to-load-unspecif
|
|
# https://discuss.rubyonrails.org/t/cve-2022-32224-possible-rce-escalation-bug-with-serialized-columns-in-active-record/81017
|
|
# FIX ME : fixes breakage of installation config. we need to migrate.
|
|
# Fix configuration in application.rb
|
|
serialize :serialized_value, coder: YAML, type: ActiveSupport::HashWithIndifferentAccess, default: {}.with_indifferent_access
|
|
|
|
before_validation :set_lock
|
|
validates :name, presence: true
|
|
validate :saml_sso_users_check, if: -> { name == 'ENABLE_SAML_SSO_LOGIN' }
|
|
|
|
# TODO: Get rid of default scope
|
|
# https://stackoverflow.com/a/1834250/939299
|
|
default_scope { order(created_at: :desc) }
|
|
scope :editable, -> { where(locked: false) }
|
|
|
|
after_commit :clear_cache
|
|
|
|
def value
|
|
serialized_value[:value]
|
|
end
|
|
|
|
def value=(value_to_assigned)
|
|
self.serialized_value = {
|
|
value: value_to_assigned
|
|
}.with_indifferent_access
|
|
end
|
|
|
|
private
|
|
|
|
def set_lock
|
|
self.locked = true if locked.nil?
|
|
end
|
|
|
|
def clear_cache
|
|
GlobalConfig.clear_cache
|
|
end
|
|
|
|
def saml_sso_users_check
|
|
return unless value == false || value == 'false'
|
|
return unless User.exists?(provider: 'saml')
|
|
|
|
errors.add(:base, 'Cannot disable SAML SSO login while users are using SAML authentication')
|
|
end
|
|
end
|