From c37cb4afbac5adcaaaa34cb3b5f0664bfffee357 Mon Sep 17 00:00:00 2001
From: Fu Diwei <fudiwei@sina.com>
Date: Fri, 25 Jul 2025 12:14:50 +0800
Subject: [PATCH] refactor: clean code

---
 internal/certificate/service.go      |  8 +++-----
 internal/domain/settings.go          | 10 ++++++++++
 internal/workflow/service.go         |  8 +++-----
 ui/src/pages/dashboard/Dashboard.tsx |  6 +++---
 4 files changed, 19 insertions(+), 13 deletions(-)

diff --git a/internal/certificate/service.go b/internal/certificate/service.go
index 4df15799..c844b17f 100644
--- a/internal/certificate/service.go
+++ b/internal/certificate/service.go
@@ -4,7 +4,6 @@ import (
 	"archive/zip"
 	"bytes"
 	"context"
-	"encoding/json"
 	"fmt"
 	"strings"
 	"time"
@@ -49,12 +48,11 @@ func (s *CertificateService) InitSchedule(ctx context.Context) error {
 			return
 		}
 
-		var settingsContent *domain.SettingsContentAsPersistence
-		json.Unmarshal([]byte(settings.Content), &settingsContent)
-		if settingsContent != nil && settingsContent.ExpiredCertificatesMaxDaysRetention != 0 {
+		persistenceSettings, _ := settings.UnmarshalContentAsPersistence()
+		if persistenceSettings != nil && persistenceSettings.ExpiredCertificatesMaxDaysRetention != 0 {
 			ret, err := s.certificateRepo.DeleteWhere(
 				context.Background(),
-				dbx.NewExp(fmt.Sprintf("validityNotAfter<DATETIME('now', '-%d days')", settingsContent.ExpiredCertificatesMaxDaysRetention)),
+				dbx.NewExp(fmt.Sprintf("validityNotAfter<DATETIME('now', '-%d days')", persistenceSettings.ExpiredCertificatesMaxDaysRetention)),
 			)
 			if err != nil {
 				app.GetLogger().Error("failed to delete expired certificates", "err", err)
diff --git a/internal/domain/settings.go b/internal/domain/settings.go
index 6ef2f4db..b3d95220 100644
--- a/internal/domain/settings.go
+++ b/internal/domain/settings.go
@@ -1,5 +1,7 @@
 package domain
 
+import "encoding/json"
+
 const CollectionNameSettings = "settings"
 
 type Settings struct {
@@ -12,3 +14,11 @@ type SettingsContentAsPersistence struct {
 	WorkflowRunsMaxDaysRetention        int `json:"workflowRunsMaxDaysRetention"`
 	ExpiredCertificatesMaxDaysRetention int `json:"expiredCertificatesMaxDaysRetention"`
 }
+
+func (s *Settings) UnmarshalContentAsPersistence() (*SettingsContentAsPersistence, error) {
+	var content *SettingsContentAsPersistence
+	if err := json.Unmarshal([]byte(s.Content), &content); err != nil {
+		return nil, err
+	}
+	return content, nil
+}
diff --git a/internal/workflow/service.go b/internal/workflow/service.go
index c90a2cb9..d7cd29ef 100644
--- a/internal/workflow/service.go
+++ b/internal/workflow/service.go
@@ -2,7 +2,6 @@ package workflow
 
 import (
 	"context"
-	"encoding/json"
 	"errors"
 	"fmt"
 	"time"
@@ -59,14 +58,13 @@ func (s *WorkflowService) InitSchedule(ctx context.Context) error {
 			return
 		}
 
-		var settingsContent *domain.SettingsContentAsPersistence
-		json.Unmarshal([]byte(settings.Content), &settingsContent)
-		if settingsContent != nil && settingsContent.WorkflowRunsMaxDaysRetention != 0 {
+		persistenceSettings, _ := settings.UnmarshalContentAsPersistence()
+		if persistenceSettings != nil && persistenceSettings.WorkflowRunsMaxDaysRetention != 0 {
 			ret, err := s.workflowRunRepo.DeleteWhere(
 				context.Background(),
 				dbx.NewExp(fmt.Sprintf("status!='%s'", string(domain.WorkflowRunStatusTypePending))),
 				dbx.NewExp(fmt.Sprintf("status!='%s'", string(domain.WorkflowRunStatusTypeRunning))),
-				dbx.NewExp(fmt.Sprintf("endedAt<DATETIME('now', '-%d days')", settingsContent.WorkflowRunsMaxDaysRetention)),
+				dbx.NewExp(fmt.Sprintf("endedAt<DATETIME('now', '-%d days')", persistenceSettings.WorkflowRunsMaxDaysRetention)),
 			)
 			if err != nil {
 				app.GetLogger().Error("failed to delete workflow history runs", "err", err)
diff --git a/ui/src/pages/dashboard/Dashboard.tsx b/ui/src/pages/dashboard/Dashboard.tsx
index bcb893d2..3e36b551 100644
--- a/ui/src/pages/dashboard/Dashboard.tsx
+++ b/ui/src/pages/dashboard/Dashboard.tsx
@@ -52,13 +52,13 @@ const Dashboard = () => {
           <Card className="transition-all max-lg:flex-1 lg:w-[280px] xl:w-[360px]" title={t("dashboard.quick_actions")}>
             <div className="flex flex-col gap-4">
               <Button block type="primary" size="large" icon={<IconCirclePlus size="1.25em" />} onClick={() => navigate("/workflows/new")}>
-                {t("dashboard.quick_actions.create_workflow")}
+                <span className="text-sm">{t("dashboard.quick_actions.create_workflow")}</span>
               </Button>
               <Button block size="large" icon={<IconLock size="1.25em" />} onClick={() => navigate("/settings/account")}>
-                {t("dashboard.quick_actions.change_password")}
+                <span className="text-sm">{t("dashboard.quick_actions.change_password")}</span>
               </Button>
               <Button block size="large" icon={<IconPlugConnected size="1.25em" />} onClick={() => navigate("/settings/ssl-provider")}>
-                {t("dashboard.quick_actions.configure_ca")}
+                <span className="text-sm">{t("dashboard.quick_actions.configure_ca")}</span>
               </Button>
             </div>
           </Card>