From 246bacd4655b8857de40b488fe1b5a4e40425b62 Mon Sep 17 00:00:00 2001 From: Fu Diwei Date: Mon, 24 Nov 2025 20:23:22 +0800 Subject: [PATCH 1/3] fix: #1057 --- internal/certmgmt/deployers/sp_1panel_site.go | 1 + 1 file changed, 1 insertion(+) diff --git a/internal/certmgmt/deployers/sp_1panel_site.go b/internal/certmgmt/deployers/sp_1panel_site.go index 564c0fd1..a49e244c 100644 --- a/internal/certmgmt/deployers/sp_1panel_site.go +++ b/internal/certmgmt/deployers/sp_1panel_site.go @@ -23,6 +23,7 @@ func init() { AllowInsecureConnections: credentials.AllowInsecureConnections, NodeName: xmaps.GetString(options.ProviderExtendedConfig, "nodeName"), ResourceType: xmaps.GetString(options.ProviderExtendedConfig, "resourceType"), + WebsiteMatchPattern: xmaps.GetString(options.ProviderExtendedConfig, "websiteMatchPattern"), WebsiteId: xmaps.GetInt64(options.ProviderExtendedConfig, "websiteId"), CertificateId: xmaps.GetInt64(options.ProviderExtendedConfig, "certificateId"), }) From cf8f5f1d9a3c229c1e71177b72e71ffa81addf38 Mon Sep 17 00:00:00 2001 From: Fu Diwei Date: Fri, 28 Nov 2025 09:47:45 +0800 Subject: [PATCH 2/3] fix: #1066 --- .../azure-keyvault/azure_keyvault.go | 2 +- pkg/core/notifier/providers/email/email.go | 13 +++++---- ui/src/components/access/AccessEditDrawer.tsx | 6 +++- .../forms/AccessConfigFieldsProviderEmail.tsx | 29 ++++++++----------- ui/src/i18n/locales/en/nls.access.json | 5 +++- ui/src/i18n/locales/zh/nls.access.json | 5 +++- 6 files changed, 34 insertions(+), 26 deletions(-) diff --git a/pkg/core/certmgr/providers/azure-keyvault/azure_keyvault.go b/pkg/core/certmgr/providers/azure-keyvault/azure_keyvault.go index 1c5aa750..66632d29 100644 --- a/pkg/core/certmgr/providers/azure-keyvault/azure_keyvault.go +++ b/pkg/core/certmgr/providers/azure-keyvault/azure_keyvault.go @@ -81,7 +81,7 @@ func (c *Certmgr) Upload(ctx context.Context, certPEM, privkeyPEM string) (*cert // REF: https://learn.microsoft.com/en-us/rest/api/keyvault/certificates/get-certificates/get-certificates listCertificatesPager := c.sdkClient.NewListCertificatePropertiesPager(nil) for listCertificatesPager.More() { - page, err := listCertificatesPager.NextPage(context.TODO()) + page, err := listCertificatesPager.NextPage(ctx) if err != nil { return nil, fmt.Errorf("failed to execute sdk request 'keyvault.GetCertificates': %w", err) } diff --git a/pkg/core/notifier/providers/email/email.go b/pkg/core/notifier/providers/email/email.go index d356812f..ae71c9ee 100644 --- a/pkg/core/notifier/providers/email/email.go +++ b/pkg/core/notifier/providers/email/email.go @@ -5,6 +5,7 @@ import ( "errors" "fmt" "log/slog" + "time" "github.com/wneessen/go-mail" @@ -65,11 +66,12 @@ func (n *Notifier) Notify(ctx context.Context, subject string, message string) ( mail.WithSMTPAuth(mail.SMTPAuthAutoDiscover), mail.WithUsername(n.config.Username), mail.WithPassword(n.config.Password), + mail.WithTimeout(time.Second * 30), } if n.config.SmtpPort == 0 { if n.config.SmtpTls { - clientOptions = append(clientOptions, mail.WithPort(mail.DefaultPortTLS)) + clientOptions = append(clientOptions, mail.WithPort(mail.DefaultPortSSL)) } else { clientOptions = append(clientOptions, mail.WithPort(mail.DefaultPort)) } @@ -85,11 +87,12 @@ func (n *Notifier) Notify(ctx context.Context, subject string, message string) ( tlsConfig.ServerName = n.config.SmtpHost } - mail.WithSSL() - mail.WithSSLPort(true) - mail.WithTLSConfig(tlsConfig) + clientOptions = append(clientOptions, mail.WithSSL()) + clientOptions = append(clientOptions, mail.WithTLSConfig(tlsConfig)) + clientOptions = append(clientOptions, mail.WithTLSPolicy(mail.TLSMandatory)) } else { - mail.WithTLSPolicy(mail.TLSOpportunistic) + clientOptions = append(clientOptions, mail.WithSSLPort(true)) + clientOptions = append(clientOptions, mail.WithTLSPolicy(mail.TLSOpportunistic)) } client, err := mail.NewClient(n.config.SmtpHost, clientOptions...) diff --git a/ui/src/components/access/AccessEditDrawer.tsx b/ui/src/components/access/AccessEditDrawer.tsx index 17536893..0604548d 100644 --- a/ui/src/components/access/AccessEditDrawer.tsx +++ b/ui/src/components/access/AccessEditDrawer.tsx @@ -174,7 +174,11 @@ const AccessEditDrawer = ({ afterSubmit, mode, data, loading, trigger, usage, .. title={
- {mode === "modify" && !!data ? t("access.action.edit.modal.title") + ` #${data.id}` : t(`access.action.${mode}.modal.title`)} + {mode === "modify" + ? data?.id + ? t("access.action.edit.modal.title") + ` #${data.id}` + : t("access.action.edit.modal.title") + : t(`access.action.${mode}.modal.title`)}