CodeCow/Scrapegraph-ai
1
0
Fork 0
mirror of https://github.com/VinciGit00/Scrapegraph-ai.git synced 2026-06-04 21:01:04 +08:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

Add review comment for PR #1027

Browse Source
This commit is contained in:
Marco Vinciguerra 2025-12-03 15:08:31 -08:00
parent cfa2fae984
commit 82fa6fd0f4
1 changed files with 7 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
PullRequests/PR_1027_reviews.md Normal file
View File

@ -0,0 +1,7 @@
This PR adds a null check for document.body before referencing document.body.scrollHeight. The motivation is that in some cases (such as non-standard DOM structures or scripts running before the DOM is fully loaded), document.body can be null, which would previously have caused runtime errors.
The fix is appropriate and covers a genuine bug that may be encountered in edge cases. The solution is concise and maintains safety without introducing unnecessary complexity. Labeling the PR as bug and size:XS is accurate. No other unintended changes observed.
If not already done, consider adding a simple test or log to ensure scrollHeight is accessed only if document.body exists, even for future contributors. Otherwise, this looks good!
✅ LGTM! Thanks for improving the robustness of the codebase.