From bf6e834f178984b77eeca414d84bec029f0902f0 Mon Sep 17 00:00:00 2001 From: emanuele-f Date: Mon, 18 Sep 2023 22:49:38 +0200 Subject: [PATCH] Fix root permission request on read from pcap INTERNET_ACROSS_USERS was requested when trying to read from a PCAP file, which triggered a failure toast in most cases --- .../main/java/com/emanuelef/remote_capture/CaptureService.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/app/src/main/java/com/emanuelef/remote_capture/CaptureService.java b/app/src/main/java/com/emanuelef/remote_capture/CaptureService.java index 218e3616..23cdafee 100644 --- a/app/src/main/java/com/emanuelef/remote_capture/CaptureService.java +++ b/app/src/main/java/com/emanuelef/remote_capture/CaptureService.java @@ -1062,7 +1062,7 @@ public class CaptureService extends VpnService implements Runnable { // Inside the mCaptureThread @Override public void run() { - if(mSettings.root_capture || mSettings.readFromPcap()) { + if(mSettings.root_capture) { // Check for INTERACT_ACROSS_USERS, required to query apps of other users/work profiles if(checkCallingOrSelfPermission(Utils.INTERACT_ACROSS_USERS) != PackageManager.PERMISSION_GRANTED) { boolean success = Utils.rootGrantPermission(this, Utils.INTERACT_ACROSS_USERS);