From 88a9c747fdec595785bc08f22eda16c392593c42 Mon Sep 17 00:00:00 2001 From: emanuele-f Date: Sun, 23 Apr 2023 19:47:40 +0200 Subject: [PATCH] Fix possible crash on firewall whitelist reload A SIGSEV occurred after a whitelist rules reload when firewall rules failed to load --- app/src/main/jni/core/pcapdroid.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/app/src/main/jni/core/pcapdroid.c b/app/src/main/jni/core/pcapdroid.c index 77536555..ea14d2cb 100644 --- a/app/src/main/jni/core/pcapdroid.c +++ b/app/src/main/jni/core/pcapdroid.c @@ -902,7 +902,7 @@ static int check_blocked_conn_cb(pcapdroid_t *pd, const zdtun_5tuple_t *tuple, p bool old_block = data->to_block; data->to_block = (data->blacklisted_internal || data->blacklisted_ip || data->blacklisted_domain); - if(!data->to_block && pd->firewall.enabled) { + if(!data->to_block && pd->firewall.enabled && fw_bl) { data->to_block = blacklist_match_uid(fw_bl, data->uid) || blacklist_match_ip(fw_bl, &dst_ip, tuple->ipver) || (data->info && data->info[0] && blacklist_match_domain(fw_bl, data->info));