CodeCow/PCAPdroid
1
0
Fork 0
mirror of https://github.com/emanuele-f/PCAPdroid.git synced 2026-07-03 21:21:12 +08:00
Code Issues Actions 4 Packages Projects Releases Wiki Activity

Add safety checks on getcwd and free memory

Browse Source
This commit is contained in:
emanuele-f 2024-09-11 18:38:50 +02:00
parent 9be48af56b
commit 50812d1de8
1 changed files with 13 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
app/src/main/jni/common/utils.c
View File

@ -239,14 +239,22 @@ int start_subprocess(const char *prog, const char *args, bool as_root, int* out_
close(in_p[0]);
// write "su" command input
// write "su"/"sh" command input
if(as_root) {
// Some su implementations (e.g. Android-x86) change the PWD when activated,
// cd to the cache dir to ensure that the UNIX socket can be found by pcapd
char* cwd = getcwd(NULL, 0);
log_d("start_subprocess[%d]: cd %s", pid, cwd);
write(in_p[1], "cd ",3);
write(in_p[1], cwd, strlen(cwd));
write(in_p[1], "\n", 1);
if (cwd) {
log_d("start_subprocess[%d]: cd %s", pid, cwd);
write(in_p[1], "cd \"",4);
write(in_p[1], cwd, strlen(cwd));
write(in_p[1], "\"\n", 2);
free(cwd);
} else
log_w("start_subprocess[%d]: getcwd failed[%d], non-magisk su may fail",
pid, errno, strerror(errno));
}
log_d("start_subprocess[%d]: %s %s", pid, prog, args);
write(in_p[1], prog, strlen(prog));
write(in_p[1], " ", 1);