+ need to (portable) install PortableApps.com's build tools (Launcher Creator, Installer Builder) on build server
+ fixing build_np3portableapp.cmd script - please read doc within this script
- unfortunately the neccessary PortableApps.com build tools do not work the same in CmdLn-Version vs. GUI-Version ???
so we have still manual interaction to build the Installer Package :-(( - try to figure out, whats going wrong in upcoming commits
+ build process is working, still some to todos left for releasing the Notepad3Portable Installer
+ option: build-time: treat warning as error (build fails)
+ cleanups reported by CppCheck v.1.79 (except issue: 'variableScope')
+ remove _CRT_SECURE_NO_WARNINGS to see security warnings for deprecated functions;
+ remove macro-definition for BOOKMARK_EDITION (bookmarks are fixed component of NP3 now)
(code has not been excaped by this MACRO consistently)
- using Linker generated manifests (knows dependencies)
- activate VS2017's postprocessing manifest-tool to merge manifest with
Version.exe's .manifest.conf part (re-embedding assembled manifest)
- by the way: Version.exe (Release/Win32) should only patch the items in
<assemblyIdentity /> node of .manifest.conf and not re-create the complete manifest wiith dependencies
(it works fine yet, but, if the Linker change dependencies, this will lead to merge conflicts)
- switching DPI awarenes to 'false', cause only MFC Application can be made DPI aware
(setting 'true' for non MFC Applications will end up in blurry effects on scaled desktops [MS doc])
- Tip: the embedded manifest resource can be checked by:
i) load the .exe via file open dialog into VS2017
ii) or using Sysinternal's > sigcheck.exe -a -m Notepad3.exe
~ maybe it is time to change to Platform Toolset "Visual Studio 2017 - Windows XP (v141_xp)" ?
- add existing recoding accelerator keys (Ctrl+Alt+F & Ctrl+Shift+A)
to "Recode" menue (func: reload file forcing this encoding type)
- add version info for used Scintilla library
~ VERSION_SCIVERSION should be set by Version.exe (version patcher)
and can be picked from provided scintilla\version.txt
- some code-cleanup (cleancode-developer pathfinder rule)
while trying to trace down notepad2-mod issue #121
(i am able to reproduce, but didn't find the reason (yet))
- fix exception - reported in notepad2-mod pull request (Crash fixing. #172), which has been rejected there,
but I was able to reproduce it in VS2017 debug mode (initial defaults for exception handling).
(https://github.com/XhmikosR/notepad2-mod/pull/172)
- incorporate changes from notepad2-mod from v.4.2.25.995 to v.4.2.25.998
(one fix, the other changes we have done before already)
- Change shortcuts for the following actions:
(-) Toggle Transparent Mode: moved from Ctrl+0 to Ctrl+Numpad_*
(x) Reset Zoom: Ctrl+/ change to Ctrl+0 ($v_5.0.26)
Additional Accelerator Keys, as suggested by (https://github.com/XhmikosR/notepad2-mod/pull/197)
(+) Toggle Line Comment : in addition to Ctrl+Q add Ctrl+/ with same functionality
(+) Do Stream Comment : in addition to Ctrl+Shift+Q add Ctrl+Shift+/ with same functionality
believing new shortcuts are more convenient and more widely used, aren't they?
