From a2ba70bb9b1732a04fb2801cb87e35481657f1a9 Mon Sep 17 00:00:00 2001
From: Rainer Kottenhoff <rainer.kottenhoff@gmail.com>
Date: Fri, 14 Jun 2019 20:42:26 +0200
Subject: [PATCH] + fix: wrong error message for error dialog box while trying
 to write to readonly file.

---
 src/Dialogs.c | 14 +++++++++-----
 1 file changed, 9 insertions(+), 5 deletions(-)

diff --git a/src/Dialogs.c b/src/Dialogs.c
index 82b84cfcc..8ded1ad8f 100644
--- a/src/Dialogs.c
+++ b/src/Dialogs.c
@@ -295,20 +295,24 @@ INT_PTR InfoBoxLng(UINT uType, LPCWSTR lpstrSetting, UINT uidMsg, ...)
     uidMsg == IDS_MUI_CREATEINI_FAIL || uidMsg == IDS_MUI_WRITEINI_FAIL ||
     uidMsg == IDS_MUI_EXPORT_FAIL || uidMsg == IDS_MUI_ERR_ELEVATED_RIGHTS) 
   {
-    WCHAR wchErr[MIDSZ_BUFFER] = { L'\0' };
+
+    LPVOID lpMsgBuf = NULL;
     FormatMessage(
       FORMAT_MESSAGE_ALLOCATE_BUFFER | FORMAT_MESSAGE_FROM_SYSTEM | FORMAT_MESSAGE_IGNORE_INSERTS,
       NULL,
       Globals.dwLastError,
       Globals.iPrefLANGID,
-      wchErr, COUNTOF(wchErr),
+      (LPWSTR)& lpMsgBuf, 0,
       NULL);
 
-    if (StrIsNotEmpty(wchErr)) {
-      StrTrim(wchErr, L" \a\b\f\n\r\t\v");
+    Globals.dwLastError = ERROR_SUCCESS; // reset;
+
+    if (lpMsgBuf) {
       StringCchCat(msgBox.lpstrMessage, COUNTOF(wchMessage), L"\n\n");
-      StringCchCat(msgBox.lpstrMessage, COUNTOF(wchMessage), wchErr);
+      StringCchCat(msgBox.lpstrMessage, COUNTOF(wchMessage), lpMsgBuf);
+      LocalFree(lpMsgBuf);
     }
+
     WCHAR wcht = *CharPrev(msgBox.lpstrMessage, StrEnd(msgBox.lpstrMessage, COUNTOF(wchMessage)));
     if (IsCharAlphaNumeric(wcht) || wcht == '"' || wcht == '\'')
       StringCchCat(msgBox.lpstrMessage, COUNTOF(wchMessage), L".");